-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to pyproject.toml #1024
move to pyproject.toml #1024
Conversation
7de648a
to
aaf5e1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1024 +/- ##
========================================
Coverage 82.18% 82.18%
========================================
Files 24 24
Lines 5171 5171
Branches 1242 1242
========================================
Hits 4250 4250
Misses 622 622
Partials 299 299 ☔ View full report in Codecov by Sentry. |
maintainers = [ | ||
{name = "Dave Foster", email = "dave@axiomdatascience.com"}, | ||
{name = "Benjamin Adams"}, | ||
{name = "Luke Campbell"}, | ||
{name = "Filipe Fernandes"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjwadams are you OK with this change? Most projects are moving away from "author" in liue for maintainers.
[project.scripts] | ||
compliance-checker = "cchecker:main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deprecated and in the future. We need a better solution to ship that script.
license-files = ["LICENSE"] | ||
zip-safe = false | ||
include-package-data = true | ||
script-files = ["cchecker.py"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8d51c4a
to
4f2af1a
Compare
Publishing to PyPI using Python 3.12 failed with:
That is likely a problem with the cf_units wheel. I'll revert to use 3.11 b/c compliance-checker is pure Python but there is a change that folks using Python 3.12 will hit that issue. |
Work in progress and not ready for review.This is the new standard for Python packaging but there are some details missing to accommodate everything we do in compliance-checker, like shipping scripts is deprecated won't be support for much longer.